feat: separateMultipleMinor #24538
Merged
feat: separateMultipleMinor #24538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phyzical
changed the title
rarkins
reviewed
Sep 20, 2023
|
Not sure if this second approach is right either 323a247 , but moved the logic away from the user configurable template over to a replace on But i suppose this is still an assumption its part of the template that is configurable. Will update the tests when i have a confirmation this way is the correct way |
rarkins
reviewed
Sep 27, 2023
rarkins
previously approved these changes
Sep 27, 2023
viceice
reviewed
Sep 27, 2023
rarkins
reviewed
Sep 27, 2023
rarkins
changed the title
rarkins
previously approved these changes
Sep 27, 2023
23 tasks
rarkins
reviewed
Sep 28, 2023
rarkins
previously approved these changes
Sep 28, 2023
rarkins
reviewed
Sep 28, 2023
rarkins
reviewed
Sep 28, 2023
rarkins
previously approved these changes
Sep 28, 2023
|
sorry forgot about this pr thanks for the nudge |
HonkingGoose
suggested changes
Mar 4, 2024
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
|
Any chance to have this merge soon? |
viceice
reviewed
Mar 16, 2024
viceice
previously approved these changes
Mar 16, 2024
|
needs deconflicting |
rarkins
previously approved these changes
Mar 18, 2024
viceice
approved these changes
Mar 24, 2024
|
🎉 This PR is included in version 37.269.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
karfau
added a commit
to bettermarks/renovate-config
that referenced
this pull request
Mar 25, 2024
since they release breaking changes in minor versions renovatebot/renovate#24538
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Attempt at supporting the
seperateMultipleMinorWill follow up with one for patch also when/is this is merged
Context
My usecase is seperating eks versions as individual prs as they are "minor versions" but you must go 1 by 1 during an update
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
below is it run for my exact usecase happy to try others if suggested
https://github.com/phyzical/renovate-tester/pulls
It works for my tiny usecase.
but I think ive done this wrong though... as i felt like i was fighting the
{{#if separateMinorPatch}}{{#if isPatch}}logic so open to feedbacki also couldn't find an example of
separateMultipleMajorbeing run from a multiple branch test context, there just seems to be hardcoded tests against static templates. or have i not looked hard enoughThanks!