Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/npm): extract currentValue from Yarn 'npm:' prefixed alias #24568

Merged
merged 8 commits into from
Sep 26, 2023
Merged

feat(manager/npm): extract currentValue from Yarn 'npm:' prefixed alias #24568

merged 8 commits into from
Sep 26, 2023

Conversation

emilbader
Copy link
Contributor

@emilbader emilbader commented Sep 21, 2023

Changes

  • Handles extraction of a valid npm: prefixed currentValue

Context

When installing packages with Yarn using its --cached option, Yarn will preferably reuse the highest version already used somewhere within the project. A side-effect is that the resolved package will look like "depName": "npm:1.x.x". This syntax is valid for Yarn but not for Renovate that claims: Invalid npm package alias: npm:1.x.x. All projects or workspaces installing dependencies with yarn add --cached will therefore not be be picked up by Renovate.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Sep 21, 2023

CLA assistant check
All committers have signed the CLA.

lib/modules/manager/npm/extract/common/dependency.ts Outdated Show resolved Hide resolved
@emilbader
Copy link
Contributor Author

@rarkins Thanks for the comments; is there anything else I should modify? If not, how does the merge process look like?

@rarkins rarkins added this pull request to the merge queue Sep 26, 2023
Merged via the queue into renovatebot:main with commit a62e656 Sep 26, 2023
34 checks passed
@emilbader emilbader deleted the feat/handle-yarn-npm-version-prefix branch September 26, 2023 14:26
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 36.108.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants