-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(manager/npm): extract currentValue from Yarn 'npm:' prefixed alias #24568
Merged
rarkins
merged 8 commits into
renovatebot:main
from
emilbader:feat/handle-yarn-npm-version-prefix
Sep 26, 2023
Merged
feat(manager/npm): extract currentValue from Yarn 'npm:' prefixed alias #24568
rarkins
merged 8 commits into
renovatebot:main
from
emilbader:feat/handle-yarn-npm-version-prefix
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
previously requested changes
Sep 21, 2023
rarkins
reviewed
Sep 22, 2023
@rarkins Thanks for the comments; is there anything else I should modify? If not, how does the merge process look like? |
rarkins
approved these changes
Sep 26, 2023
🎉 This PR is included in version 36.108.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
npm:
prefixedcurrentValue
Context
When installing packages with Yarn using its
--cached
option, Yarn will preferably reuse the highest version already used somewhere within the project. A side-effect is that the resolved package will look like"depName": "npm:1.x.x"
. This syntax is valid for Yarn but not for Renovate that claims:Invalid npm package alias: npm:1.x.x
. All projects or workspaces installing dependencies withyarn add --cached
will therefore not be be picked up by Renovate.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: