New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cargo): support private crate #24704
feat(cargo): support private crate #24704
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an entry in in cargo/index.md that this is happening.
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Thanks for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First pass review, needs more work after.
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@HonkingGoose I've applied your suggestions. |
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with the docs, but I want a maintainer to review the left and right side of the Markdown diff. I suspect we're accidentally dropping some information.
🎉 This PR is included in version 37.5.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes
For the Cargo manager, I've enabled by default net.git-fetch-with-cli.
I also enable hostRule for passing token to pull private crate (like it's done for Golang)
Context
Closes #20059
Cargo, in Renovate, could not pull private crate when updating artifacts.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
I've updated the snapshot to see the new Cargo config, and I tested it locally pointing to a repo with a private crate.
It's my first PR, I hope I did not miss something.