Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(config options): explain prCreation=approval #24949

Merged

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Explain what happens when you set prCreation to approval

Context

The current docs list approval as a valid allowedValues, but lacks a proper explanation.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Co-authored-by: Rhys Arkins <rhys@arkins.net>
rarkins and others added 2 commits October 2, 2023 15:36
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
docs/usage/configuration-options.md Outdated Show resolved Hide resolved
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@rarkins rarkins added this pull request to the merge queue Oct 3, 2023
Merged via the queue into renovatebot:main with commit 3a19e5e Oct 3, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose deleted the docs/explain-prCreation-approval branch October 3, 2023 11:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants