feat(hostRules): support https options and platform in host rules from env #25015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyonlai
changed the title
rarkins
requested changes
Oct 4, 2023
viceice
reviewed
Oct 10, 2023
rarkins
previously approved these changes
Oct 18, 2023
rarkins
previously approved these changes
Oct 19, 2023
|
@rarkins 👋 how are we looking for the merge? are we still waiting for anything? |
|
Awaiting second review |
|
@viceice would you take a second review on this please? |
|
@rarkins there seems to be no progress on the second review for the past week. Any other member that could perform a second review to get this going? |
rarkins
changed the title
|
@viceice can you merge if this looks ok to you? |
viceice
reviewed
Oct 30, 2023
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins
approved these changes
Oct 31, 2023
|
🎉 This PR is included in version 37.37.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
jon4hz
pushed a commit
to jon4hz/renovate
that referenced
this pull request
Nov 9, 2023
…m env (renovatebot#25015) Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
made
hostRulesFromEnvable to:Context
As per changes for discussion of moving setGlobalHostRules before platform initialisation. Renovate needs to be able to pickup https options from environment variable and apply before platform initialisation.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: