feat(vendir): add vendir support #25113

knechtionscoding · 2023-10-09T23:57:00Z

Currently only supports the helmChart dependency, but provides a framework for other types of dependencies in vendir

Changes

Adds support for the Vendir manager when using helmCharts
Builds framework for supporting other types of vendir dependencies

Context

Closes #17711

Documentation (please check one with an [x])

I have updated the documentation

How I've tested my work (please select one)

I have verified these changes via:

Both unit tests + ran on a real repository

Test PRs:

Currently only supports the helmChart dependency, but provides a framework for other types of dependencies in vendir Co-authored-by: Zoltán Reegn <reegnz@users.noreply.github.com>

CLAassistant · 2023-10-09T23:57:06Z

All committers have signed the CLA.

knechtionscoding · 2023-10-10T00:44:39Z

@rarkins I think I have this mostly working (working through some final small things). But I would love a cursory glance.

I also would love to know how the kustomize manager works.

I used the kustomize and helmv3 managers as examples. What I didn't see in the case of kustomize but did in the case of helmv3 is a bumpVersion function.

Where does that happen for kustomize? Do I need to write a bumpVersion function? Or does the new version just show up somewhere properly?

And I can't get the tests to pass for artifact.ts. I appear to be having a problem with adding all non-vendir.lock.yml files. I tried both the kustomize, helm, and gomod method and cannot get it to work properly. Can you give me some pointers on that?

feat(vendir): check types correctly Co-authored-by: Zoltán Reegn <reegnz@users.noreply.github.com>

knechtionscoding · 2023-11-22T13:52:19Z

@rarkins would love some feedback on this PR, would love to get vendir support added natively

lib/modules/manager/vendir/artifacts.spec.ts

lib/modules/manager/vendir/artifacts.ts

lib/modules/manager/vendir/extract.spec.ts

lib/modules/manager/vendir/extract.ts

package.json

chore: revert package.json change chore: run prettier

fix: inline function fix: remove resetAllMocks Co-authored-by: Zoltán Reegn <reegnz@users.noreply.github.com>

lib/modules/manager/vendir/README.md

lib/modules/manager/vendir/extract.ts

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

fix: add back conditional for vendirSync properly docs: update vendir readme

lib/modules/manager/vendir/__fixtures__/empty-directory.yaml

lib/modules/manager/vendir/artifacts.spec.ts

lib/modules/manager/vendir/artifacts.ts

viceice · 2024-03-15T18:24:54Z

please avoid force push, we squash merge, so no worries about git history

viceice

nice work, nearly done

lib/modules/manager/vendir/__fixtures__/empty-directories.yaml

lib/modules/manager/vendir/extract.spec.ts

lib/modules/manager/vendir/extract.ts

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

fix: remove unnecessary check fix: remove utils tests: update tests results to reflect better naming tests: inline emptydirectories

lib/modules/manager/vendir/readme.md

lib/modules/manager/vendir/artifacts.ts

lib/modules/manager/vendir/extract.spec.ts

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

renovate-release · 2024-03-21T16:31:03Z

🎉 This PR is included in version 37.264.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat(vendir): provides support for vendir manager

84e31d4

Currently only supports the helmChart dependency, but provides a framework for other types of dependencies in vendir Co-authored-by: Zoltán Reegn <reegnz@users.noreply.github.com>

feat(vendir): add support for running vendir sync

85585b4

feat(vendir): properly run vendir sync

0f36351

feat(vendir): check types correctly Co-authored-by: Zoltán Reegn <reegnz@users.noreply.github.com>

knechtionscoding marked this pull request as ready for review October 10, 2023 13:32

viceice requested changes Nov 22, 2023

View reviewed changes

knechtionscoding and others added 5 commits February 7, 2024 07:35

fix: swap toMatchObject to toEqual

068951f

chore: revert package.json change chore: run prettier

Merge branch 'main' into feat/vendir-support

ebb429e

chore: run prettier

d68c8e3

fix: use yaml lib

10b9154

fix: inline function fix: remove resetAllMocks Co-authored-by: Zoltán Reegn <reegnz@users.noreply.github.com>

chore: remove extra import

bb50539

HonkingGoose reviewed Mar 4, 2024

View reviewed changes

lib/modules/manager/vendir/README.md Outdated Show resolved Hide resolved

lib/modules/manager/vendir/README.md Outdated Show resolved Hide resolved

lib/modules/manager/vendir/extract.ts Show resolved Hide resolved

knechtionscoding and others added 9 commits March 4, 2024 10:35

Update lib/modules/manager/vendir/README.md

91d52e8

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

Update lib/modules/manager/vendir/README.md

e773e29

Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>

fix failing tests

3113d95

Merge branch 'main' into feat/vendir-support

030c4ea

fix: linters

a229cea

Fix lint

75ddfb6

Add helm OCI registry support

0791bd5

chore: lint fix

9ac3cc7

Drop unnecessary code paths

1377c97

knechtionscoding requested a review from viceice March 14, 2024 15:46

fix: Add files correctly

42c7ae4

fix: add back conditional for vendirSync properly docs: update vendir readme

viceice reviewed Mar 15, 2024

View reviewed changes

knechtionscoding added 2 commits March 15, 2024 18:16

feat: passing tests

47ecf1e

fix: pr comments

49ad5c7

knechtionscoding force-pushed the feat/vendir-support branch from 8151a04 to 49ad5c7 Compare March 15, 2024 18:06

tests: alias test properly

478a9c9

knechtionscoding requested review from viceice and HonkingGoose March 20, 2024 14:20

viceice reviewed Mar 20, 2024

View reviewed changes

knechtionscoding and others added 4 commits March 20, 2024 15:36

Update lib/modules/manager/vendir/extract.spec.ts

b7c8a1e

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

Update lib/modules/manager/vendir/extract.ts

a84203d

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

feat: add regex for validation on URL

64b9854

fix: remove unnecessary check fix: remove utils tests: update tests results to reflect better naming tests: inline emptydirectories

docs: add info to readme on aliases

21f3c38

knechtionscoding requested a review from viceice March 20, 2024 15:50

knechtionscoding added 3 commits March 20, 2024 17:46

fix: remove aliases from http/https as it isn't needed

63af329

fix: test pass

2dc9a1b

docs: remove # line

91d094e

viceice reviewed Mar 21, 2024

View reviewed changes

knechtionscoding and others added 7 commits March 21, 2024 14:48

Update lib/modules/manager/vendir/readme.md

1cbe927

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

Update lib/modules/manager/vendir/readme.md

c56a312

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

Update lib/modules/manager/vendir/extract.spec.ts

4e39123

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

Update lib/modules/manager/vendir/extract.spec.ts

45d432e

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

Update lib/modules/manager/vendir/artifacts.ts

e572110

Co-authored-by: Michael Kriese <michael.kriese@visualon.de>

Drop unnecessary branch

a4b8933

Fix lint issue

cda1c74

viceice approved these changes Mar 21, 2024

View reviewed changes

viceice added this pull request to the merge queue Mar 21, 2024

Merged via the queue into renovatebot:main with commit db1b0d8 Mar 21, 2024
37 checks passed

reegnz deleted the feat/vendir-support branch March 21, 2024 16:22

This was referenced Mar 28, 2024

chore: remove types.ts from vendir as it is unused knechtionscoding/renovate#1

Closed

chore: remove types.ts from vendir as it is unused #28166

Merged

reegnz mentioned this pull request Apr 15, 2024

Add post sync ability to rename files carvel-dev/vendir#250

Open

github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(vendir): add vendir support #25113

feat(vendir): add vendir support #25113

knechtionscoding commented Oct 9, 2023 •

edited

CLAassistant commented Oct 9, 2023 •

edited

knechtionscoding commented Oct 10, 2023 •

edited

knechtionscoding commented Nov 22, 2023

viceice commented Mar 15, 2024

viceice left a comment

renovate-release commented Mar 21, 2024

feat(vendir): add vendir support #25113

feat(vendir): add vendir support #25113

Conversation

knechtionscoding commented Oct 9, 2023 • edited

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

CLAassistant commented Oct 9, 2023 • edited

knechtionscoding commented Oct 10, 2023 • edited

knechtionscoding commented Nov 22, 2023

viceice commented Mar 15, 2024

viceice left a comment

Choose a reason for hiding this comment

renovate-release commented Mar 21, 2024

knechtionscoding commented Oct 9, 2023 •

edited

CLAassistant commented Oct 9, 2023 •

edited

knechtionscoding commented Oct 10, 2023 •

edited