Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "build(deps): update opentelemetry-js monorepo (#25474)" #25503

Conversation

gizero
Copy link
Contributor

@gizero gizero commented Oct 30, 2023

See #25464, #25473 and #25474 for context.

This PR re-applies the rollback from #25473 while updating renovate.json to add an entry to packageRules that helps gating new updates behind dependencyDashboardApproval. This last config change could be dropped as soon as a new version of the opentelemetry monorepo is released with the relevant fixes. Thanks @HonkingGoose for suggesting the configuration change to prevent auto-mergeable updates to keep rendering the rollback effort useless.

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

I tested changes from this PR with by running renovate against the rolled back sources and with the help of RENOVATE_BASE_BRANCHES and RENOVATE_USE_BASE_BRANCH_CONFIG=merge and checked logs for:

         {
           "branchName": "renovate/opentelemetry-js-monorepo",
           "prNo": null,
           "prTitle": "build(deps): update opentelemetry-js monorepo",
           "result": "needs-approval",
           "upgrades": [
             {
               "datasource": "npm",
               "depName": "@opentelemetry/context-async-hooks",
               "displayPending": "",
               "fixedVersion": "1.17.0",
               "currentVersion": "1.17.0",
               "currentValue": "1.17.0",
               "newValue": "1.17.1",
               "newVersion": "1.17.1",
               "packageFile": "package.json",
               "updateType": "patch",
               "packageName": "@opentelemetry/context-async-hooks"
             },
[...]

@gizero gizero force-pushed the rollback-opentelemetry-js-monorepo-and-gate-future-updates branch from 6c9103c to b945aa0 Compare October 30, 2023 16:46
@gizero gizero changed the title Rollback opentelemetry js monorepo and gate future updates (again) fix: Revert "build(deps): update opentelemetry-js monorepo (#25474)" Oct 30, 2023
@gizero gizero force-pushed the rollback-opentelemetry-js-monorepo-and-gate-future-updates branch from b945aa0 to 7c5833e Compare October 30, 2023 16:49
@gizero gizero marked this pull request as draft October 30, 2023 16:50
@gizero gizero force-pushed the rollback-opentelemetry-js-monorepo-and-gate-future-updates branch from 7c5833e to 590f574 Compare October 30, 2023 16:52
@gizero gizero marked this pull request as ready for review October 30, 2023 16:57
@rarkins rarkins added this pull request to the merge queue Oct 30, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the GitHub issue to the PR description

"@opentelemetry/exporter-trace-otlp-http": "0.44.0",
"@opentelemetry/instrumentation": "0.44.0",
"@opentelemetry/context-async-hooks": "1.17.0",
"@opentelemetry/exporter-trace-otlp-http": "0.43.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should only revert the 0.44.0 versions or only this package, as only here is a bug.

Merged via the queue into renovatebot:main with commit 3a0788a Oct 30, 2023
51 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.36.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

gizero added a commit to gizero/renovate that referenced this pull request Nov 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants