Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(presets): add extractVersion to regex managers #25591

Merged

Conversation

maxbrunet
Copy link
Contributor

Changes

As in title

Context

I often find the need to trim a prefix from some versions.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor
Copy link
Collaborator

secustor commented Nov 5, 2023

Needs prettier fix

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rarkins do you see any problem with exposing this from an UX perspective?

@rarkins
Copy link
Collaborator

rarkins commented Nov 6, 2023

@secustor at first I didn't like the sounds of it, but if it's as elegant as this, I'm happy to merge it unless/until we find a problem

@rarkins rarkins added this pull request to the merge queue Nov 6, 2023
Merged via the queue into renovatebot:main with commit 65dc335 Nov 6, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

jon4hz pushed a commit to jon4hz/renovate that referenced this pull request Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants