Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation/reporting): add report option #26087

Merged
merged 16 commits into from Mar 17, 2024

Conversation

secustor
Copy link
Collaborator

@secustor secustor commented Dec 2, 2023

Changes

Add two options to allow the export reports containing the status of and extracted dependencies with updates.

Context

This is part of my effort to allow integration in Backstage

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still missing some explanation about what reports are, and what use they are to me as Renovate user. Is that already explained somewhere else in the docs maybe?

docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
lib/config/options/index.ts Outdated Show resolved Hide resolved
lib/config/types.ts Outdated Show resolved Hide resolved
lib/instrumentation/reporting.ts Show resolved Hide resolved
lib/instrumentation/reporting.ts Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/instrumentation/reporting.ts Outdated Show resolved Hide resolved
lib/instrumentation/reporting.ts Outdated Show resolved Hide resolved
@secustor
Copy link
Collaborator Author

I'm still missing some explanation about what reports are, and what use they are to me as Renovate user. Is that already explained somewhere else in the docs maybe?

This is rather not for usage by end users, but rather ease integrations such as assisted creating of support requests on the app.
When we stabilize this and if we offer contracts in regard to the containing data.

@secustor secustor marked this pull request as ready for review February 24, 2024 00:00
test/util.ts Outdated Show resolved Hide resolved
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise lgtm

lib/instrumentation/reporting.spec.ts Outdated Show resolved Hide resolved
@viceice
Copy link
Member

viceice commented Mar 4, 2024

conflicted 😉

@secustor secustor requested a review from viceice March 17, 2024 05:23
lib/config/validation.ts Outdated Show resolved Hide resolved
lib/instrumentation/reporting.spec.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@secustor secustor requested a review from viceice March 17, 2024 08:02
@secustor secustor added this pull request to the merge queue Mar 17, 2024
Merged via the queue into renovatebot:main with commit 481aa21 Mar 17, 2024
35 checks passed
@secustor secustor deleted the feat/add-reports branch March 17, 2024 09:30
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.251.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants