Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: install with frozen #26135

Merged
merged 2 commits into from
Dec 5, 2023
Merged

ci: install with frozen #26135

merged 2 commits into from
Dec 5, 2023

Conversation

viceice
Copy link
Member

@viceice viceice commented Dec 5, 2023

Changes

it seems pnpm doesn't detect CI from action, so we need to explicit use frozen lockfile

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@secustor
Copy link
Collaborator

secustor commented Dec 5, 2023

Should be the case 🤔
https://pnpm.io/cli/install#--frozen-lockfile

@viceice viceice added this pull request to the merge queue Dec 5, 2023
@viceice
Copy link
Member Author

viceice commented Dec 5, 2023

Should be the case 🤔
https://pnpm.io/cli/install#--frozen-lockfile

I know, but it's strangely not working as expected. see linked PR's

Merged via the queue into main with commit 283fbeb Dec 5, 2023
36 checks passed
@viceice viceice deleted the ci/fix-lockfile branch December 5, 2023 10:14
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.83.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants