Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Escape literal . in Bitbucket module ref regex #26452

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

JanGe
Copy link
Contributor

@JanGe JanGe commented Dec 29, 2023

Changes

Escapes a . in Terraform manager's Bitbucket Ref regex. The .git sequence should be interpreted literally instead of as <any_character>git.

Context

Currently Renovate's Terraform manager is failing to properly parse the package name in Bitbucket Git module sources when the URI path contains the word git.

Example:

module "example" {
  source = "git::ssh://git@bitbucket.org/workspace/repo.git//path_with_git?depth=1&ref=v2.0.0"
}

The regex currently parses

  • Group workspace as workspace/repo.git/. Expected: workspace
  • Group project as path_with. Expected: repo
  • Group subfolder as empty string. Expected: /path_with_git

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins added this pull request to the merge queue Dec 29, 2023
Merged via the queue into renovatebot:main with commit 831fba0 Dec 29, 2023
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.111.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants