fix(platform/gerrit): Check for comment size limit #26454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
If generated message too big request to gerrit will fail with: One or more comments were rejected in validation: Comment size exceeds limit (16437 > 16384) Avoid this by truncating messages before posting them.
viceice
changed the title
viceice
requested changes
Dec 29, 2023
viceice
approved these changes
Dec 30, 2023
viceice
changed the title
|
🎉 This PR is included in version 37.112.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
zT-1337
pushed a commit
to scm-manager/renovate
that referenced
this pull request
Jan 22, 2024
zT-1337
pushed a commit
to scm-manager/renovate
that referenced
this pull request
Jan 24, 2024
zT-1337
pushed a commit
to scm-manager/renovate
that referenced
this pull request
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If generated message too big request to gerrit will fail with:
Avoid this by truncating messages before posting them.
Changes
Fix minor issue with gerrit integration.
Context
While testing new gerrit integration I found in some cases (long changelog) it might fail to create changeset. It is the fix for the issue.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: