fix(manager/terragrunt): add missing registry host #26681
Merged
+15
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added registry url to extraction result at Terragrunt Manager when source uses tfr protocol and contains custom registry hostname. Fixes: renovatebot#26668
rarkins
approved these changes
Jan 16, 2024
|
🎉 This PR is included in version 37.137.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
viceice
reviewed
Jan 16, 2024
Comment on lines
+75
to
+77
| if (tfrVersionMatch.groups.registry) { | ||
| dep.registryUrls = [`https://${tfrVersionMatch.groups.registry}`]; | ||
| } |
There was a problem hiding this comment.
should only be set if not default registry
zT-1337
pushed a commit
to scm-manager/renovate
that referenced
this pull request
Jan 22, 2024
zT-1337
pushed a commit
to scm-manager/renovate
that referenced
this pull request
Jan 24, 2024
zT-1337
pushed a commit
to scm-manager/renovate
that referenced
this pull request
Jan 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added registry url to extraction result at Terragrunt Manager when source uses tfr protocol and contains custom registry hostname.
Now, if the source link in a Terragrunt file using
tfr://protocol contains a hostname it is included in the extraction result inside theregistryUrlsproperty. For example, given the followingterraformblock:The extraction of dependencies will produce the following dependency:
{ "depType": "terragrunt", "depName": "abc/helloworld/aws", "currentValue": "1.0.0", "datasource": "terraform-module", "registryUrls": [ "https://registry.domain.com" ] }Context
Closes: #26668
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: