Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(manager/npm): handle pnpm lockfile updates #26770

Merged
merged 20 commits into from Feb 22, 2024
Merged

feat(manager/npm): handle pnpm lockfile updates #26770

merged 20 commits into from Feb 22, 2024

Conversation

guillaumeduboc
Copy link
Contributor

@guillaumeduboc guillaumeduboc commented Jan 20, 2024 •
edited by viceice

Changes

This pr adds support for pnpm lockfile updates

Context

This pr makes possible the rangeStrategy='update-lockfile' for pnpm

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@guillaumeduboc guillaumeduboc mentioned this pull request Jan 20, 2024
Closed
@guillaumeduboc guillaumeduboc changed the title feat: handle pnpm lockfile updates feat(manager/npm): handle pnpm lockfile updates Jan 20, 2024
viceice
viceice reviewed Jan 21, 2024
View reviewed changes
lib/modules/manager/npm/post-update/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/post-update/pnpm.spec.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/post-update/pnpm.spec.ts Show resolved Hide resolved
lib/modules/manager/npm/post-update/pnpm.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Jan 22, 2024
View reviewed changes
lib/modules/manager/npm/post-update/pnpm.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/post-update/pnpm.ts Outdated Show resolved Hide resolved
lib/modules/manager/npm/post-update/pnpm.ts Outdated Show resolved Hide resolved
viceice
viceice reviewed Feb 18, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

lib/modules/manager/npm/post-update/pnpm.ts Outdated Show resolved Hide resolved
viceice
viceice previously approved these changes Feb 18, 2024
View reviewed changes
@secustor secustor added this pull request to the merge queue Feb 22, 2024
Merged via the queue into renovatebot:main with commit 11658df Feb 22, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.207.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@guillaumeduboc guillaumeduboc deleted the feat/pnpm-lockfile-update branch February 22, 2024 18:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

@secustor secustor secustor approved these changes

@reece-white reece-white reece-white approved these changes

@rarkins rarkins Awaiting requested review from rarkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support rangeStrategy=update-lockfile for pnpm
5 participants
@guillaumeduboc @renovate-release @viceice @secustor @reece-white