fix(datasource/go): private repositories on azure #26984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix a bug that occurs with private go packages with a major version greater than 1 on Azure DevOps. The problem is that Azure DevOps has support for go-get metadata but it will only work for modules that are included without a version suffix attached, like dev.azure.com/<org>/<project>/_git/<repo>.git/v2 Once such a suffix is part of the URL the http request to fetch the metadata info will result in 404 Not Found error. This change will now fetch the releases for the module as git tags from the repository. The Azure DevOps documentation https://learn.microsoft.com/en-us/azure/devops/repos/git/go-get describes two ways to name go packages: dev.azure.com/<org>/<project>/_git/<repo>.git and dev.azure.com/<org>/<project>/<repo>.git Both possible names are changed to https://dev.azure.com/<org>/<project>/_git/<repo> to have a valid Azure DevOps https git URL.
rarkins
reviewed
Feb 1, 2024
rarkins
reviewed
Feb 26, 2024
rarkins
reviewed
Feb 26, 2024
rarkins
previously approved these changes
Feb 27, 2024
with the recent changes there is no chanche to trigger the azure fall back detection.
the old fall back detection for azure modules is not reachable anymore. The fall back could be removed or ignored by the linter to fix it. I chose to ignore it. |
viceice
requested changes
Feb 28, 2024
viceice
approved these changes
Feb 29, 2024
|
🎉 This PR is included in version 37.220.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix a bug that occurs with private go packages with a major version greater than 1 on Azure DevOps.
Changes
This change will fetch the releases for a go package on Azure DevOps as git tags from the repository.
It will support the two described ways to name a go package on Azure DevOps by changing the package name to a valid Azure DevOps https git URL.
Context
The problem is that Azure DevOps has support for go-get metadata but it will only work for modules that are included without a version suffix attached, like
dev.azure.com/<org>/<project>/_git/<repo>.git/v2. Once such a suffix is part of the URL the http request to fetch the metadata info will result in404 Not Founderror.This change will now fetch the releases for the module as git tags from the repository.
The Azure DevOps documentation describes two ways to name go packages:
dev.azure.com/<org>/<project>/_git/<repo>.gitdev.azure.com/<org>/<project>/<repo>.gitBoth possible names are changed to
https://dev.azure.com/<org>/<project>/_git/<repo>.Closes #14347
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: