feat(kustomize): support OCI helm charts #27163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
chancez
force-pushed
the
pr/chancez/kustomize_oci_charts
branch
from
ab65a2d
to
af2accb
Compare
viceice
requested changes
Feb 9, 2024
viceice
reviewed
Feb 12, 2024
6 tasks
viceice
reviewed
Mar 13, 2024
viceice
reviewed
Mar 13, 2024
viceice
reviewed
Mar 13, 2024
viceice
previously approved these changes
Mar 13, 2024
viceice
reviewed
Mar 13, 2024
viceice
approved these changes
Mar 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
🎉 This PR is included in version 37.243.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Awesome thanks everyone! |
|
I'm glad to report that I'm seeing this working in a few of my repos now. 🎉 |
|
I just went back into @thomaschaaf's minimal reproduction repo below and it got me thinking: is this working fully as desired yet? See: Here's what Renovate changed in that issue description ~18 hours ago: |
|
please open a new discussion |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Correctly handle OCI charts with the kustomize manager. This requires setting the datasource to
dockerand replacing theoci://scheme withhttps://. For the implementation, I simply adapted the approach used in the helmv3 manager. I do think there's more to do in terms of support, like digests, and probably auth, but for my use-case, this was sufficient. I tested with, and without auth against a quay.io registry.Context
Renovate was updated to handle updating helmCharts within a
kustomization.yamlin #12628. However, in Kustomize 5.2.0 it got support for inflating helm charts stored in OCI repositories. Currently renovate fails to update these dependencies because it simply treats OCI helm repos the same as regular helm repos, and fails.There were similar issues with other managers, but nothing for Kustomize that I could find. The related issues for other managers I found are:
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: