Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replacements): fakerjs to scoped #27206

Merged
merged 3 commits into from Feb 11, 2024
Merged

feat(replacements): fakerjs to scoped #27206

merged 3 commits into from Feb 11, 2024

Conversation

ST-DDT
Copy link
Contributor

@ST-DDT ST-DDT commented Feb 9, 2024

Changes

Created a replacement rule to replace the unmaintained faker with the community driven replacement @faker-js/faker

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why so many rules?

@Shinigami92
Copy link

why so many rules?

I don't really understand your question 🤔
Each rule serves different purposes. If someone is e.g. on v4, then switching the npm scope directly to v5.5.3 would result in breaking changes.
The new home kept the whole history and released backward-compatible legacy versions that were not changed.

@ST-DDT
Copy link
Contributor Author

ST-DDT commented Feb 10, 2024

why so many rules?

I thought this was some kind of requirement:

1. Replacement PRs should ideally propose a replacement only once the user is on a compatible version, by specifying a compatible `matchCurrentVersion` constraint
1. If no compatible replacement upgrade is possible, it's acceptable to propose an incompatible one (e.g. a major version upgrade)
1. Replacements should update the user to the first recommended version of the new dependency and not include any new changes - whether breaking or not - if they can be avoided

Especially the specifying a compatible `matchCurrentVersion` constraint + not include any new changes - whether breaking or not part

And fastify does the same

matchCurrentVersion: '>=3.3.0 <4.0.0',
matchDatasources: ['npm'],
matchPackageNames: ['fastify-accepts-serializer'],
replacementName: '@fastify/accepts-serializer',
replacementVersion: '4.0.0',
},
{
matchCurrentVersion: '>=2.3.0 <3.0.0',
matchDatasources: ['npm'],
matchPackageNames: ['fastify-accepts'],
replacementName: '@fastify/accepts',
replacementVersion: '3.0.0',

I can change them to all/only point to 5.5.3 if you want.

@Shinigami92
Copy link

I can change them to all/only point to 5.5.3 if you want.

I would suggest to NOT do that, because it violates:

Replacement PRs should ideally propose a replacement only once the user is on a compatible version, by specifying a compatible `matchCurrentVersion` constraint

rarkins
rarkins previously approved these changes Feb 10, 2024
@secustor secustor added this pull request to the merge queue Feb 11, 2024
Merged via the queue into renovatebot:main with commit 85d95a5 Feb 11, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.183.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ST-DDT ST-DDT deleted the feat/replacements/fakerjs-to-scoped branch February 11, 2024 23:25
not7cd pushed a commit to uni-intelligence/renovate that referenced this pull request Feb 13, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants