Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/pip-compile): Add lockedVersion to package file deps #27242

Merged

Conversation

not7cd
Copy link
Contributor

@not7cd not7cd commented Feb 12, 2024

Changes

This adds dep.lockedVersion to every dependency in every package file. Locked versions are taken from a first lock file found. Further locked versions from other lock files are ignored.
A warning is raised if dep is found without a lock.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@not7cd not7cd force-pushed the not7cd/pip-compile-lockedVersion branch 2 times, most recently from b46202c to deb5ae5 Compare February 13, 2024 14:57
@not7cd not7cd force-pushed the not7cd/pip-compile-lockedVersion branch from deb5ae5 to 50e0c24 Compare February 13, 2024 15:14
@not7cd not7cd marked this pull request as ready for review February 13, 2024 15:22
@not7cd not7cd requested a review from viceice February 13, 2024 17:17
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@not7cd not7cd requested a review from viceice February 14, 2024 14:41
viceice
viceice previously approved these changes Feb 15, 2024
@viceice
Copy link
Member

viceice commented Feb 15, 2024

Ups, conflicted 🙃

Co-authored-by: Rhys Arkins <rhys@arkins.net>
@not7cd not7cd changed the title feat(manager/pip-compile): add lockedVersion to package file deps feat(manager/pip-compile): Add lockedVersion to package file deps Feb 15, 2024
@not7cd not7cd requested a review from rarkins February 15, 2024 11:14
@rarkins rarkins added this pull request to the merge queue Feb 15, 2024
Merged via the queue into renovatebot:main with commit 0ba9e35 Feb 15, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.192.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants