Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redis): keepalive ping (30s) #27249

Merged
merged 3 commits into from Feb 14, 2024

Conversation

rvanbutselaar
Copy link
Contributor

@rvanbutselaar rvanbutselaar commented Feb 12, 2024

Changes

Added Redis keepalive ping (in ms) to 10 seconds.

"Azure Cache for Redis" has a 10-minute timeout for idle connections. We are running renovate against a large amount of repositories. The auto-discovering of repositories takes more then 10 minutes. And we are hitting the 10-minute timeout on the Redis connection:

DEBUG: Auto-discovering repositories
DEBUG: hostRules: applying Bearer authentication for ***
__classPrivateFieldGet(this, _RedisSocket_instances, "m", _RedisSocket_onSocketError).call(this, new errors_1.SocketClosedUnexpectedlyError());
                                                                                                                     ^
SocketClosedUnexpectedlyError: Socket closed unexpectedly
    at Socket.<anonymous> (/workspaces/renovate/node_modules/.pnpm/@redis+client@1.5.13/node_modules/@redis/client/dist/lib/client/socket.js:195:118)
    at Object.onceWrapper (node:events:633:26)
    at Socket.emit (node:events:518:28)
    at Socket.emit (node:domain:488:12)
    at TCP.<anonymous> (node:net:337:12)
 ELIFECYCLE  Command failed with exit code 1

To resolve this, Azure advices to configure the pingInterval when creating a Redis connection.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rvanbutselaar rvanbutselaar changed the title Redis keepalive ping (in ms) fix(redis): keepalive ping (in ms) Feb 12, 2024
@viceice viceice requested a review from rarkins February 14, 2024 08:44
@rarkins rarkins changed the title fix(redis): keepalive ping (in ms) fix(redis): keepalive ping (30s) Feb 14, 2024
@rarkins rarkins added this pull request to the merge queue Feb 14, 2024
Merged via the queue into renovatebot:main with commit 0867de8 Feb 14, 2024
34 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.188.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants