Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update dependency semver to v7.6.0 #27255

Merged
merged 4 commits into from Mar 19, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 12, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
semver 7.5.4 -> 7.6.0 age adoption passing confidence

Release Notes

npm/node-semver (semver)

v7.6.0

Compare Source

Features
Chores

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot enabled auto-merge February 12, 2024 18:12
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes Feb 12, 2024
renovate-approve[bot]
renovate-approve bot previously approved these changes Feb 12, 2024
@renovate renovate bot force-pushed the renovate/semver-7.x branch 4 times, most recently from 1534812 to b5f4485 Compare February 12, 2024 20:02
@viceice
Copy link
Member

viceice commented Feb 12, 2024

@rarkins @secustor WDYT about the comment above?

@secustor
Copy link
Collaborator

I think we should keep our own logic, as it is more integrated the general processing.

@renovate renovate bot force-pushed the renovate/semver-7.x branch 9 times, most recently from b83ca3e to 0f28be8 Compare February 14, 2024 07:37
@viceice
Copy link
Member

viceice commented Feb 14, 2024

I think we should keep our own logic, as it is more integrated the general processing.

Ok, i see, the new behavior is optional 🙈

@renovate renovate bot force-pushed the renovate/semver-7.x branch 7 times, most recently from 99618b7 to 27bdae8 Compare February 14, 2024 11:02
renovate-approve[bot]
renovate-approve bot previously approved these changes Feb 16, 2024
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes Feb 16, 2024
renovate-approve[bot]
renovate-approve bot previously approved these changes Feb 17, 2024
renovate-approve-2[bot]
renovate-approve-2 bot previously approved these changes Feb 17, 2024
| datasource | package | from  | to    |
| ---------- | ------- | ----- | ----- |
| npm        | semver  | 7.5.4 | 7.6.0 |
Copy link
Contributor Author

renovate bot commented Feb 18, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

# Conflicts:
#	pnpm-lock.yaml
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this new semver behavior makes sense as default

@rarkins rarkins disabled auto-merge March 18, 2024 21:19
@rarkins rarkins requested a review from secustor March 18, 2024 21:19
@rarkins
Copy link
Collaborator

rarkins commented Mar 18, 2024

I get 100% coverage result for this locally. The error here is Error: Unable to download artifact(s): Failed to ListArtifacts: Unexpected token '<', "<!DOCTYPE "... is not valid JSON

@secustor secustor added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit b881173 Mar 19, 2024
37 checks passed
@secustor secustor deleted the renovate/semver-7.x branch March 19, 2024 05:56
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.256.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

@NubeNueve NubeNueve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib/modules/versioning/conan/range.ts

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants