Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/azure-pipelines): Add Azure DevOps project support #27277

Merged

Conversation

robjackstewart
Copy link
Contributor

Changes

  • Add support for bumping Azure Pipeline template dependencies across different Azure DevOps projects by making the current repository accessible as part of the ExtractConfig interface.
  • Add logic to determine the target Azure DevOps when looking for dependency updates.

Context

When an azure pipeline template declares an Azure Repos repository resource, the name of the repository may be prefixed with the Azure DevOps project name e.g. repo: Project/Repository. However, the project name is not mandatory and omitting it makes the reference to the current project implicit.

For example:
If a repository called MyRepository is in Azure DevOps project MyProject, and there is an Azure Pipelines YAML file which declares a repository resource as repo: MyOtherRepository, then Azure Pipelines assumes that MyOtherRepository is in project MyProject. Whereas if MyOtherRepository was in a different project it would need to be declared as repo: MyOtherProject/MyOtherRepository.

Renovate cannot currently update dependencies if the project is implicit because we do not pass in context about the repository being processed to the manager.

Supporting discussion.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2024

CLA assistant check
All committers have signed the CLA.

@robjackstewart robjackstewart force-pushed the add-azure-pipeline-project-calc branch 4 times, most recently from a566e19 to 86c4af6 Compare February 13, 2024 22:03
@robjackstewart robjackstewart marked this pull request as ready for review February 13, 2024 22:04
@robjackstewart robjackstewart changed the title Add azure pipeline project calc feat(manager/azure-pipeline): Add Azure DevOps project support Feb 13, 2024
@robjackstewart robjackstewart changed the title feat(manager/azure-pipeline): Add Azure DevOps project support feat(manager/azure-pipelines): Add Azure DevOps project support Feb 13, 2024
Copy link
Contributor Author

@robjackstewart robjackstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah damn! I'll fix up those unit tests.

@viceice
Copy link
Member

viceice commented Mar 10, 2024

needs test updates

@robjackstewart
Copy link
Contributor Author

needs test updates

Tests show now be fixed.

@rarkins rarkins enabled auto-merge March 10, 2024 18:21
@rarkins rarkins added this pull request to the merge queue Mar 10, 2024
Merged via the queue into renovatebot:main with commit 3313b72 Mar 10, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.235.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants