Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add manual changelog URLs for logback and slf4j #27373

Merged
merged 5 commits into from Feb 29, 2024

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Feb 17, 2024

Changes

Added manual changelog URLs for

Both are widely adopted logging library in JVM world.

Context

Implements a feature discussed in #22893

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@exoego exoego changed the title Add manual changelog URLs for logback and slf4j feat: Add manual changelog URLs for logback and slf4j Feb 17, 2024
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be proper full maven package names

@exoego
Copy link
Contributor Author

exoego commented Feb 17, 2024

@rarkins Sorry, added full maven package names in 0e7ed5f

@exoego
Copy link
Contributor Author

exoego commented Feb 28, 2024

Could you merge this?
Logback 1.5.1 was released on Feb 28th.

@rarkins rarkins added this pull request to the merge queue Feb 29, 2024
Merged via the queue into renovatebot:main with commit f6fc128 Feb 29, 2024
35 checks passed
@exoego exoego deleted the custom-changelog-logback branch February 29, 2024 05:35
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.220.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants