Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(string pattern matching): rewrite #27414

Merged
merged 4 commits into from Feb 27, 2024

Conversation

HonkingGoose
Copy link
Collaborator

Changes

  • Use simple words and phrases
  • Chop up complicated sentence into a list
  • Use one sentence per line pattern
  • Convert complicated lists to tables
  • Use you to address the reader
  • Use must to indicate requirements
  • Add headings to allow users to skim
  • Add admonition to warn users to escape the backslashes before copy/pasting from regex101
  • Emphasize key words in the negative matching section

Context

Follow up after:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

docs/usage/string-pattern-matching.md Outdated Show resolved Hide resolved
docs/usage/string-pattern-matching.md Show resolved Hide resolved
docs/usage/string-pattern-matching.md Show resolved Hide resolved
docs/usage/string-pattern-matching.md Show resolved Hide resolved
@rarkins rarkins added this pull request to the merge queue Feb 27, 2024
Merged via the queue into renovatebot:main with commit 752d252 Feb 27, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.214.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@HonkingGoose HonkingGoose deleted the docs/string-pattern-matching branch February 27, 2024 10:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants