New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new keepUpdatedLabel config setting #27542
Conversation
This config setting will keep a PR updated if it has the keepUpdatedLabel label set in the PR. This allows a user to opt-in a PR to continual updating, even if rebaseWhen is set to never or conflicted.
I had expected it should behave like rebaseWhen=behind-base-branch, not auto. Why don't think auto is a better approach? In some cases auto won't update the PR, which would seem like a bug to the user if you've configured a keepUpdatedLabel |
You're right, I would expect this to behave like I tested this on a repo with the "require branches be up-to-date" setting both on and off. In both cases if the |
Co-authored-by: Rhys Arkins <rhys@arkins.net>
Co-authored-by: Rhys Arkins <rhys@arkins.net>
👀 it looks like |
I pushed a commit that should bump reuse.ts coverage to 100% |
@rarkins Ok, I think I've got the final coverage reports back up to 100%. I missed that requirement when I was running tests locally. 🤦 Do you prefer to resolve the open conversations yourself? |
🎉 This PR is included in version 37.222.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes
This adds the
keepUpdatedLabel
config setting.Adding the
keepUpdatedLabel
label to a PR makes Renovate behaveas if
rebaseWhen
were set tobehind-base-branch
, but only for the given PR. The label is not removed from the PRafter the rebase is complete, unlike
rebaseLabel
.This can be useful when you have approved certain PRs and want to keep them updated until they are ready
to be merged. The setting
keepUpdatedLabel
is best used in conjunction withrebaseWhen
set to thevalues of
never
orconflicted
that limit rebasing.Context
The motivation for this change came out of the discussion about managing the use of renovate bot alongside kodiakhq bot: #27328. It was suggested by the Renovate maintainer that a new option could be added that allowed a user to opt-in given PRs to rebase updates.
This provides an implementation of that option from my best understanding of the existing code. It mostly follows the use of
rebaseWhen
, modifying the behavior ifkeepUpdatedLabel
is set and the label is included on the PR.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: