Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(options): only show confidence badges if version is available #27654

Merged
merged 2 commits into from Mar 1, 2024

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Mar 1, 2024

This prevents broken badges when digest updates are grouped together with version updates.

Changes

Adds some conditionals to the relevant prBodyDefinitions so that the badges are not rendered when the new version is not available.

Context

#27407

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

⚒️ with ❤️ by Siemens

This prevents broken badges when digest updates are grouped together with version updates.
@fgreinacher fgreinacher marked this pull request as ready for review March 1, 2024 08:48
@viceice viceice added this pull request to the merge queue Mar 1, 2024
Merged via the queue into renovatebot:main with commit 2dd7f40 Mar 1, 2024
51 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.222.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@fgreinacher fgreinacher deleted the fix/badges-conditional branch March 4, 2024 09:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants