Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/docker): fix getDigest when lookupName different from packageName #27665

Merged
merged 1 commit into from Mar 1, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 1, 2024

Changes

Store both registryUrl (already) and lookupName (new, this PR) after getReleases() call and use them for the getDigest() call.

Context

Fixes #26161

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice March 1, 2024 12:51
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 1, 2024

@viceice some of the tests results change relate to Docker test you wrote, including some visualon examples. Can you make sure they still keep working for you? I'm actually surprised we didn't see this problem more.

@viceice
Copy link
Member

viceice commented Mar 1, 2024

@viceice some of the tests results change relate to Docker test you wrote, including some visualon examples. Can you make sure they still keep working for you? I'm actually surprised we didn't see this problem more.

ups, didn't read that

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a more detailed review

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viceice viceice added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 42081a3 Mar 1, 2024
35 checks passed
@viceice viceice deleted the fix/26161-docker-digest-lookup branch March 1, 2024 21:38
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.222.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants