Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sbt): initialize registry urls for sbt version #27667

Merged
merged 2 commits into from Mar 1, 2024

Conversation

lpriyasivakumar
Copy link
Contributor

Changes

The PR #27276 caused a bug since the registry urls were not initialized when fetching sbt version from build.properties. This fixes the bug by initializing the array. Added a test to cover this scenario as well.

Context

Closes issue #27653

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@lpriyasivakumar
Copy link
Contributor Author

@rarkins @secustor Let me know if the fix looks good or if any more validations are necessary. Thank you!

@rarkins rarkins enabled auto-merge March 1, 2024 14:47
@rarkins rarkins added this pull request to the merge queue Mar 1, 2024
Merged via the queue into renovatebot:main with commit 6da8fdc Mar 1, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.221.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lpriyasivakumar lpriyasivakumar deleted the fix/null-registries branch March 10, 2024 21:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants