Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/docker): Allow ecr and ecr-fips docker registry for AWS. #27680

Merged
merged 4 commits into from Mar 5, 2024

Conversation

nan-coupa
Copy link
Contributor

Changes

AWS ECR should support the following URLs:

  • *.dkr.ecr.us-east-1.amazonaws.com
  • *.dkr.ecr-fips.us-east-1.amazonaws.com

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

AWS ECR should support the following URLs:
* `*.dkr.ecr.us-east-1.amazonaws.com`
* `*.dkr.ecr-fips.us-east-1.amazonaws.com`
@nan-coupa nan-coupa changed the title Allow ecr and ecr-fips docker registry for AWS. fix(datasource/docker): Allow ecr and ecr-fips docker registry for AWS. Mar 1, 2024
rarkins
rarkins previously approved these changes Mar 2, 2024
@rarkins rarkins enabled auto-merge March 2, 2024 05:51
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs lint fix

lib/modules/datasource/docker/ecr.ts Outdated Show resolved Hide resolved
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
rarkins
rarkins previously approved these changes Mar 2, 2024
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still needs a prettier fix

auto-merge was automatically disabled March 5, 2024 18:05

Head branch was pushed to by a user without write access

@nan-coupa
Copy link
Contributor Author

@viceice I ran prettier to fix the lint issue.

@viceice viceice enabled auto-merge March 5, 2024 19:11
@viceice viceice added this pull request to the merge queue Mar 5, 2024
Merged via the queue into renovatebot:main with commit 83e1c91 Mar 5, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.229.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants