Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource/docker): better reuse of lookupName for getDigest #27724

Merged
merged 2 commits into from Mar 5, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 5, 2024

Changes

Adds lookupName to getDigest params instead of overloading packageName.

Context

Fixes #27723

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Adds lookupName to getDigest params instead of overloading packageName.

Fixes #27723
@rarkins rarkins requested a review from viceice March 5, 2024 08:24
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 5, 2024

@viceice can you test again against your visualon requirements?

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@rarkins rarkins merged commit d5f3d6f into main Mar 5, 2024
34 checks passed
@rarkins rarkins deleted the fix/27723-docker-digest-lookup-name branch March 5, 2024 14:02
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.227.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker datasource getDigest() is not parsed correctly for gcr.io/google.com/cloudsdktool/cloud-sdk
3 participants