fix(circleci): correctly get a Orb name when a line has an inline comment #27736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
previously approved these changes
Mar 6, 2024
auto-merge was automatically disabled
March 6, 2024 05:55
Head branch was pushed to by a user without write access
|
Sorry, I missed the lint issue. https://github.com/renovatebot/renovate/actions/runs/8165249110/job/22327783865?pr=27736 I have fixed that by f280b08 |
rarkins
approved these changes
Mar 6, 2024
|
🎉 This PR is included in version 37.229.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Correctly get an Orb name when a line has an inline comment.
Context
YAML allows us to write an inline comment like the following.
But Renovate can't parse this line now. Renovate treats an inline comment as a part of an Orb name. This PR fixes that and removes a comment from an Orb name.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: