Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/regex/tests): actually test 'combination' strategy #27756

Merged

Conversation

amezin
Copy link
Contributor

@amezin amezin commented Mar 6, 2024

Changes

Actually test "combination" strategy in tests that have "extracts with combination strategy" in their name. They were testing "any" strategy instead.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins enabled auto-merge March 6, 2024 14:49
@rarkins rarkins added this pull request to the merge queue Mar 6, 2024
Merged via the queue into renovatebot:main with commit 8b44771 Mar 6, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.229.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@viceice
Copy link
Member

viceice commented Mar 6, 2024

@rarkins this should be test scope, release was unnecessary for a test only change. 🙃

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants