Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for go-templates in argocd yaml files #27766

Merged
merged 1 commit into from Mar 7, 2024

Conversation

lstoeferle
Copy link
Contributor

Changes

Hi everyone,
we recently discovered that Renovate silently skips Argo CD yaml-files, that are wrapped in go-templates like in the following example:

{{- if .Values.enabled }}
apiVersion: argoproj.io/v1alpha1
kind: Application
spec:
  source:
    chart: kube-state-metrics
    repoURL: https://prometheus-community.github.io/helm-charts
    targetRevision: 2.4.1
{{- end }}

Context

Closes #27762

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice enabled auto-merge March 7, 2024 07:57
@viceice viceice added this pull request to the merge queue Mar 7, 2024
Merged via the queue into renovatebot:main with commit 10c8182 Mar 7, 2024
35 checks passed
@lstoeferle lstoeferle deleted the feat/argocd-go-templates branch March 7, 2024 08:34
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.231.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants