Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(yarn): set http proxy config from environment variables #27794

Merged
merged 2 commits into from Mar 8, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 8, 2024

Changes

Runs yarn global config commands to set http(s) proxy if the environment variables are set.

Context

Yarn does not recognize the environment variables natively

Documentation (please check one with an [x])

  • [=x] I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice March 8, 2024 09:07
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 8, 2024

I could verify that these proxy commands were run, and that Yarn install picked them up, although curiously Yarn didn't error when the proxy was invalid - it happily downloaded directly and continued.

@rarkins rarkins added this pull request to the merge queue Mar 8, 2024
Merged via the queue into main with commit 049c59c Mar 8, 2024
35 checks passed
@rarkins rarkins deleted the feat/27793-yarn-proxy branch March 8, 2024 11:37
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.232.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lukeapage
Copy link
Contributor

This breaks our setup because we want a proxy for renovate, but we don't want a proxy for yarn because its using internal servers. and because yarn doesn't support no-proxy, we can't tell yarn not to use a proxy :/

It seems ridiculous but would you be open to a config option that stops this feature happening?

@viceice
Copy link
Member

viceice commented Mar 15, 2024

please open a new discussion and reference this PR and the corresponding issue.

@fgreinacher
Copy link
Contributor

This breaks our setup because we want a proxy for renovate, but we don't want a proxy for yarn because its using internal servers. and because yarn doesn't support no-proxy, we can't tell yarn not to use a proxy :/

It seems ridiculous but would you be open to a config option that stops this feature happening?

This discussion continues at #27983.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants