feat(github-actions): support ratchet comments #27846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
approved these changes
Mar 11, 2024
viceice
approved these changes
Mar 11, 2024
viceice
changed the title
HonkingGoose
suggested changes
Mar 11, 2024
HonkingGoose
approved these changes
Mar 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
🎉 This PR is included in version 37.239.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mkurde
reviewed
Mar 15, 2024
| This means that Renovate will: | ||
|
|
||
| - update the version of a _pinned_ Ratchet version if needed | ||
| - not delete Ratchet comments after parsing them |
There was a problem hiding this comment.
This is not true.
The result is still "good" as its valid but the documentation or the code should be updated.
There was a problem hiding this comment.
@art-shutter and @rarkins can you check this review comment?
There was a problem hiding this comment.
@mkurde please open a new discussion and reference this pr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds support for comments format used by
ratchettool.Context
The
ratchettool is a locally run tool that helps update github workflows dependencies locally. This is especially useful in monorepos containing several separately-versioned github actions / workflows. As aratchetuser I would like to keep the functionality ratchet is offering me and combine it withrenovate. This PR makes sure the desired pin is extracted fromratchetcomments and thatratchetcomments don't get deleted by renovate, including theratchet:excludecomments.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: