Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): inheritConfig #27864

Merged
merged 43 commits into from Mar 23, 2024
Merged

feat(config): inheritConfig #27864

merged 43 commits into from Mar 23, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 12, 2024

Changes

Adds new inherited org config option

Context

Closes #22212

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested a review from viceice March 12, 2024 06:20
@rarkins rarkins changed the title refactor: config file parsing feat(config): inheritConfig Mar 12, 2024
@rarkins rarkins mentioned this pull request Mar 12, 2024
Merged
6 tasks
Base automatically changed from refactor/file-parse to main March 12, 2024 07:46
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 12, 2024

Blocked by #27891

@rarkins rarkins changed the base branch from main to refactor/validate-config-type March 12, 2024 19:48
@rarkins rarkins marked this pull request as draft March 12, 2024 19:51
Base automatically changed from refactor/validate-config-type to main March 13, 2024 05:19
@rarkins
Copy link
Collaborator Author

rarkins commented Mar 20, 2024

Documented as part of #28035

secustor
secustor previously approved these changes Mar 20, 2024
View reviewed changes
viceice
viceice reviewed Mar 21, 2024
View reviewed changes
docs/usage/self-hosted-configuration.md Show resolved Hide resolved
lib/workers/repository/init/inherited.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.spec.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.ts Outdated Show resolved Hide resolved
viceice
viceice previously approved these changes Mar 23, 2024
View reviewed changes
lib/config/index.ts Show resolved Hide resolved
lib/workers/repository/init/inherited.spec.ts Outdated Show resolved Hide resolved
secustor
secustor previously approved these changes Mar 23, 2024
View reviewed changes
@rarkins rarkins dismissed stale reviews from secustor and viceice via e1c272d March 23, 2024 07:53
@rarkins rarkins enabled auto-merge March 23, 2024 07:56
@rarkins rarkins added this pull request to the merge queue Mar 23, 2024
Merged via the queue into main with commit e4ab753 Mar 23, 2024
37 checks passed
@rarkins rarkins deleted the feat/22212-inherited-org-config branch March 23, 2024 08:21
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.267.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RahulGautamSingh RahulGautamSingh RahulGautamSingh left review comments

@secustor secustor secustor approved these changes

@HonkingGoose HonkingGoose HonkingGoose approved these changes

@viceice viceice Awaiting requested review from viceice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default org config
6 participants
@rarkins @renovate-release @viceice @secustor @HonkingGoose @RahulGautamSingh