Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github-actions): add support for version tag prefixes #27882

Merged
merged 8 commits into from Mar 13, 2024

Conversation

art-shutter
Copy link
Contributor

@art-shutter art-shutter commented Mar 12, 2024

Changes

This adds support of tags with prefixes (like whatever-prefix-v1.2.0) to github-actions manager.

Context

Support of version tags with prefixes is useful for reusable actions contained in monorepos and versioned separately. Example: a monorepo containing three actions: "action-one", "action-two", "action-three" all being released with different version tags, "action-one-v1.3.0", "action-two-v2.1.0", "action-three-v1.3.1". Renovatebot should be able to parse such tags and follow them when they are pinned.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

When reviewing please have a look into how the new accepted format of version tags gets interpreted in terms of semver etc.

rarkins
rarkins previously approved these changes Mar 12, 2024
@rarkins rarkins requested a review from viceice March 12, 2024 15:52
@viceice viceice added the auto:no-done-comments Don't say "Done" or "Please review" - request a review instead label Mar 13, 2024
Copy link
Contributor

Hi there,

You are using done comments which cause a lot of noise/notifications. Instead, please use GitHub's web interface to request another review. Please read our contributing guidelines to reduce noise.

Good luck,

The Renovate team

@viceice viceice enabled auto-merge March 13, 2024 17:09
@viceice viceice added this pull request to the merge queue Mar 13, 2024
@rarkins rarkins changed the title feat: add support for version tag prefixes to github-actions manager feat(github-actions): add support for version tag prefixes Mar 13, 2024
Merged via the queue into renovatebot:main with commit 27eb84f Mar 13, 2024
36 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.244.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@milpog
Copy link

milpog commented Mar 15, 2024

Is there similar functionality available for git-tags and/or github-tags?

@viceice
Copy link
Member

viceice commented Mar 15, 2024

please open a new discussion

@milpog
Copy link

milpog commented Mar 15, 2024

please open a new discussion

Sure. I think I found already opened discussion for that 🤔

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto:no-done-comments Don't say "Done" or "Please review" - request a review instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants