Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cache): Revert "refactor: Initialize caches before repository init" #27908

Merged
merged 1 commit into from Mar 13, 2024
Merged

fix(cache): Revert "refactor: Initialize caches before repository init" #27908

merged 1 commit into from Mar 13, 2024

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 13, 2024 •
edited by viceice

Reverts #27897

The refactor of init meant that the repo fingerprint wasn't available, which meant it wasn't written to the cache.
Then on the second run on the new/bad version it failed to parse the cache with zod due to the missing fingerprint

@rarkins rarkins enabled auto-merge March 13, 2024 12:26
@rarkins rarkins added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit eb5f0a7 Mar 13, 2024
35 checks passed
@rarkins rarkins deleted the revert-27897-feat/init-caches-before-repo branch March 13, 2024 12:36
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.241.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rarkins @renovate-release @viceice