Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow packageScope in template compilation and add packageScope in maven datasource #27925

Merged

Conversation

lyonlai
Copy link
Contributor

@lyonlai lyonlai commented Mar 14, 2024

Changes

This PR allows packageScope to be compiled in template module and adds packageScope in maven datasource.

This feature makes maven datasource to be able to pickup artifact groupId as the packageScope and allows the packageScope to be used in groupName so that we could group maven artifact update by its group name.

example configuration

{
  packageRules: [
    {
       matchManagers: [
          'gradle'
       ],
       groupName: "{{packageScope}}"
    }
  ]
}

Context

#27721

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would ideally support npm too!

lib/util/template/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@rarkins rarkins requested a review from viceice March 15, 2024 05:09
@rarkins rarkins added this pull request to the merge queue Mar 15, 2024
Merged via the queue into renovatebot:main with commit 397dda5 Mar 15, 2024
35 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.247.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants