Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(nuget): add hint for protocol version in NuGet.config #27933

Merged
merged 2 commits into from Mar 18, 2024

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Mar 14, 2024

Changes

Update NuGet docs to mention how to define the protocol version for feeds in NuGet.config files.

Context

I forgot to update this documentation in #5757. Funnily this was nearly four years ago and nobody noticed :)

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

⚒️ with ❤️ by Siemens

@fgreinacher fgreinacher marked this pull request as ready for review March 14, 2024 10:40
viceice
viceice previously approved these changes Mar 15, 2024
docs/usage/nuget.md Outdated Show resolved Hide resolved
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the docs and layout. I'll let the maintainers review for technical accuracy.

@rarkins rarkins added this pull request to the merge queue Mar 18, 2024
Merged via the queue into renovatebot:main with commit de9608b Mar 18, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.255.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants