Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/github-actions): extract complex github tags #27941

Merged
merged 1 commit into from Mar 26, 2024

Conversation

Yokann
Copy link
Contributor

@Yokann Yokann commented Mar 14, 2024

Changes

Github Action manager

Removing version control from the extractor allows more tuning with packageRules
It should be the responsibility of the versioning updater to check the version's validity.

Context

Github Action extractor skipped entries when we tried to use tags with a prefix like:

uses: monorepo/actions/workflows/deployment.yaml@deployment-v1
uses: monorepo/actions/workflows/tests.yaml@test-v1.2

I want Renovate to be allowed to upgrade to version deployment-v2 with this kind of package rule:

packageRules: [
    {
      matchDatasources: ["github-tags"],
      matchPackageNames: ["monorepo/actions"],
      versioning: "docker",
      versionCompatibility: "^(?<compatibility>.*)-v(?<version>.*)$",
    },
  ]

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2024

CLA assistant check
All committers have signed the CLA.

@Yokann Yokann marked this pull request as ready for review March 15, 2024 11:53
@jycamier

This comment has been minimized.

@Yokann Yokann force-pushed the feat/extraxt-customversion-gha branch from 5285134 to d2d8ea2 Compare March 26, 2024 11:03
fix

feat(manager/github-actions): remove action version checker from extractor

s
@Yokann Yokann force-pushed the feat/extraxt-customversion-gha branch from d2d8ea2 to fb6f058 Compare March 26, 2024 11:08
@rarkins rarkins requested a review from viceice March 26, 2024 13:57
@rarkins rarkins added this pull request to the merge queue Mar 26, 2024
Merged via the queue into renovatebot:main with commit 6ad6022 Mar 26, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.271.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Yokann Yokann deleted the feat/extraxt-customversion-gha branch March 26, 2024 15:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants