test(manager): manager need to exports updateDependency or extractPackageFile when exporting extractAllPackageFiles
#27954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xtractPackageFile` when exporting `extractAllPackageFiles`
vtintillier
reviewed
Mar 15, 2024
Co-authored-by: Vivien Tintillier <vtintillier.privatedev@gmail.com>
auto-merge was automatically disabled
March 15, 2024 14:05
Head branch was pushed to by a user without write access
viceice
approved these changes
Mar 15, 2024
viceice
changed the title
updateDependency or extractPackageFile when exporting extractAllPackageFilesupdateDependency or extractPackageFile when exporting extractAllPackageFiles
viceice
changed the title
updateDependency or extractPackageFile when exporting extractAllPackageFilesupdateDependency or extractPackageFile when exporting extractAllPackageFiles
|
🎉 This PR is included in version 37.250.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adjust the manager validation to check that each manager, which exports
extractAllPackageFilesmust as well exportupdateDependencyorextractPackageFile.This is required because Renovate will use
extractPackageFileto check if a dependency got successfully updated. Without havingextractPackageFileexported Renovate can't perform updates. The alternative for this is that a manager provides an ownupdateDependencymethod. ThenextractPackageFileis not needed.Context
Found this as part of the investigation of #27935 and the fix #27953
Requires #27953 to be merged for tests to passis merged and tests are passing nowDocumentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: