feat: allow templating of the extends field

[lstoeferle]

Changes

Hi everyone,
this PR adds the extends field to the allowed field for handlebars templating to add some QOL for self-hosted config presets within the same directory like the self-host-config.

Self-Hosted configuration

module.exports = {
  customEnvVariables: {
    GITLAB_REF: process.env.CI_COMMIT_REF_NAME,
  },
}

Repository configuration

{
  extends: ["local>foo/bar#{{ env.GITLAB_REF }}"]
}

Context

#27952

Documentation (please check one with an [x])

• I have updated the documentation, or
• No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

• Code inspection only, or
• Newly added/modified unit tests, or
• No unit tests but ran on a real repository, or
• Both unit tests + ran on a real repository

[viceice]

wrong, doesn't work that way

[lstoeferle]

There's one issue with the replacements:messageFormat-{{package}}-to-@messageformat/{{package}} preset, since it contains {{package}}. I've added a presetTemplateIgnoredFields config, which skips the template compilation in case any of the values are present in the template string.

[rarkins]

I don't think that templating based on package is a valid concept. extends fields are evaluated during repository intialization, which is before any packages are detected. I think we need to go back to the discussion to understand better what you're trying to do

[lstoeferle]

I don't think that templating based on package is a valid concept. extends fields are evaluated during repository intialization, which is before any packages are detected. I think we need to go back to the discussion to understand better what you're trying to do

It's not my intention to do templating base on package 😉 The problem is, that there is an existing preset which is called replacements:messageFormat-{{package}}-to-@messageformat/{{package}}, which includes the handlebars {{package}}. So in the end there will be replacements:messageFormat--to-@messageformat/, since it will be filled with an empty string by default.

I've added a more detailed scenario here: #27952 (comment)

[rarkins]

Let's rename that messageFormat-{{package} one - plus add a migration - and ideally add a test that such names don't include handlebars syntax in future

[lstoeferle]

Let's rename that messageFormat-{{package} one - plus add a migration - and ideally add a test that such names don't include handlebars syntax in future

Applied the changes. For the test I'm not quite sure how/where to implement that.

[viceice]

there should be a note that only a small subset of options can be used in template

[HonkingGoose]

I'll let a maintainer check the Renovate code and the configuration examples.

[HonkingGoose]

Sorry for crossing wires on the PR reviews with the lead maintainer. 😉

I'll let the maintainer review again. 🙃

[lstoeferle]

@rarkins may I ask you for a final approval? 😇

[renovate-release]

🎉 This PR is included in version 37.363.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)
• 37.363.0

Your semantic-release bot 📦🚀