feat(datasource): Add Unity3D #27971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This adds 41k lines to the repo. Can the fixtures be reduced? |
|
Should be possible! I've only copied the responses directly from Unity's official feeds, to keep the tests as close to real life as possible, but I'll see how much I can remove while keeping all tests intact to get the size down. |
…sions required to pass tests
|
Addressed it in b6aabde:
|
secustor
requested changes
Mar 17, 2024
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
secustor
requested changes
Mar 20, 2024
fix: Resolves issue where a double slash is added (`https://unity.com//releases` -> `https://unity.com/releases`)
secustor
approved these changes
Mar 25, 2024
|
🎉 This PR is included in version 37.270.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
viceice
reviewed
Mar 26, 2024
|
|
||
| export class Unity3dDatasource extends Datasource { | ||
| static readonly homepage = 'https://unity.com/'; | ||
| static readonly streams: { [key: string]: string } = { |
There was a problem hiding this comment.
should use Record<string,string> instead
| registryUrl: string | undefined, | ||
| withHash: boolean, | ||
| ): Promise<ReleaseResult | null> { | ||
| let channel = null; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a datasource for updating the runtime of a project using the Unity game engine.
Context
See #27219, implements part of #27295.
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: