Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Compact HTTP cache stats #28011

Merged

Conversation

zharinov
Copy link
Collaborator

Changes

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@zharinov zharinov requested a review from rarkins March 18, 2024 21:35
@zharinov
Copy link
Collaborator Author

DEBUG: HTTP cache statistics (repository=renovate-testing/source-url-1)
       "https://api.github.com/repos/renovate-testing/source-url-1/pulls": {"hit": 1, "miss": 0},
       "https://api.github.com/repos/renovate-testing/source-url-1/contents/renovate.json": {"hit": 2, "miss": 0},
       "https://registry.npmjs.org/zod": {"hit": 0, "miss": 0, "localHit": 1}

rarkins
rarkins previously approved these changes Mar 18, 2024
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be shorted/grouped to per-host?

@zharinov
Copy link
Collaborator Author

DEBUG: HTTP cache statistics (repository=renovate-testing/source-url-1)
       "https://api.github.com": {
         "/repos/renovate-testing/source-url-1/contents/renovate.json": {
           "hit": 2,
           "miss": 0
         },
         "/repos/renovate-testing/source-url-1/pulls": {"hit": 1, "miss": 0}
       },
       "https://registry.npmjs.org": {"/zod": {"hit": 1, "miss": 0, "localMiss": 1}}

@zharinov zharinov changed the title refactor: Make HTTP cache stats more compact refactor: Compact HTTP cache stats Mar 19, 2024
@rarkins rarkins added this pull request to the merge queue Mar 19, 2024
Merged via the queue into renovatebot:main with commit 5e02f6e Mar 19, 2024
37 checks passed
@rarkins rarkins deleted the refactor/rename-http-cache-stat-fields branch March 19, 2024 15:15
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.257.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants