feat: add support for git refs for vendir #28084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Mar 22, 2024
fix: remove git, not installable on the fly fix: add back types.ts
viceice
reviewed
Mar 24, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
You had asked me to condense the fixtures in a previous comment. So it feels like doing 1/3 of the condensing here just because and then a second PR is... Odd? Either I follow the pattern for vendir from the previous PR of having separate fixtures and will condense if desired completely in a separate PR. Or I'll do it now. But leaving it part way done/inconsistent doesn't seem right. |
2 tasks
viceice
reviewed
Mar 28, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
viceice
approved these changes
Mar 28, 2024
|
🎉 This PR is included in version 37.274.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
secustor
pushed a commit
to secustor/renovate
that referenced
this pull request
Mar 31, 2024
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds support for gitRefs (but not revisionSelections/Ranges) to the Vendir Manager. Vendir supports lots of different upstream/sources this is a commonly used one.
Context
After merging support for helmCharts via Vendir this PR adds support for gitRefs as well
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: