Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding includes helper for templating #28148

Conversation

juancarlosjr97
Copy link
Contributor

@juancarlosjr97 juancarlosjr97 commented Mar 27, 2024

Changes

Adding a custom helper for handlebars as includes that will check if a list of strings will be valid for a template configuration.

  • Add includes handlebars

Context

#27818

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

All tests are passing locally with 100% code coverage

This has been tested also on a PR with a public project juancarlosjr97/renovate-test-27818#13

Commit updated by template: juancarlosjr97/renovate-test-27818@791e2ae

chore(deps): update all dependencies
Jest Dependency
{
  "$schema": "https://docs.renovatebot.com/renovate-schema.json",
  "extends": ["config:base", "group:all"],
  "packageRules": [
    {
      "matchDepTypes": ["*"],
      "addLabels": ["jest"]
    },
    {
      "matchPackagePatterns": ["*"],
      "labels": ["jest"],
      "commitBody": "{{#if (includes labels 'jest')}}Jest Dependency{{else}}Other Libraries{{/if}}"
    }
  ],
  "fetchChangeLogs": "off"
}

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@juancarlosjr97
Copy link
Contributor Author

Pick the changes from #27939 to merge the includes handlebars and then work on the other changes of the depTypes for templating.

@juancarlosjr97 juancarlosjr97 marked this pull request as ready for review March 27, 2024 06:12
docs/usage/templates.md Outdated Show resolved Hide resolved
@rarkins rarkins enabled auto-merge March 27, 2024 19:22
@rarkins rarkins added this pull request to the merge queue Mar 27, 2024
Merged via the queue into renovatebot:main with commit e4020c1 Mar 27, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.273.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@juancarlosjr97 juancarlosjr97 deleted the 27818-adding-includes-helper-templating branch March 27, 2024 20:04
secustor pushed a commit to secustor/renovate that referenced this pull request Mar 31, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants