New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve minor/patch confusion in config #2818
Comments
I noticed that `updateTypes: ['patch']` only matches if `separateMinorPatch` is set to true. This comes somewhat unexpected and does not seem to be documented anywhere at the moment, as opposed to the documentation of the `patch` setting, where the docs correctly state `Only applies if separateMinorPatch is set to true`. Maybe related to renovatebot#2818 But without reading the docs, I would expect `updateTypes: ['patch']` to always match on patch updates (e.g. 1.0.0 to 1.0.1) regardless of the `separateMinorPatch` setting (which is only set if we want separate PRs or branches for patch AND minor updates)
I think we should flip this with next major |
It's a non-trivial logic change so we'll need to make sure we test it thoroughly and think of whether there's any highly undesirable behavior changes that would result, assuming the majority of users won't update their config prior. There may also be some presets we want to update the definition of to get as much backwards compatibility that way |
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
Changes behavior so that patch updateType is not rewritten to minor by default. Closes #2818 BREAKING CHANGE: patch updates are not considered updateType=minor by default.
🎉 This issue has been resolved in version 25.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
How do I keep the old behaviour?
Splits patch and minor's in 2 PRs. I want them in one PR. |
Can you create a reproduction repo and then a new discussion? We may need to experiment |
Initially Renovate did not support breaking out patch updates from minor updates - they were both considered "minor", so the only two update types were major and minor. We still default to separateMinorPatch=false and the majority of users keep this default. In this case it internally means we still break into major/minor.
The problem: too many edge cases where users do want to apply special rules to patch but have not enabled separateMinorPatch.
If we change our internal logic to always classify into major/minor/patch then it definitely will result in a change of behaviour for some.
The text was updated successfully, but these errors were encountered: