Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve minor/patch confusion in config #2818

Closed
rarkins opened this issue Nov 13, 2018 · 5 comments · Fixed by #9393
Closed

Resolve minor/patch confusion in config #2818

rarkins opened this issue Nov 13, 2018 · 5 comments · Fixed by #9393
Assignees
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started

Comments

@rarkins
Copy link
Collaborator

rarkins commented Nov 13, 2018

Initially Renovate did not support breaking out patch updates from minor updates - they were both considered "minor", so the only two update types were major and minor. We still default to separateMinorPatch=false and the majority of users keep this default. In this case it internally means we still break into major/minor.

The problem: too many edge cases where users do want to apply special rules to patch but have not enabled separateMinorPatch.

If we change our internal logic to always classify into major/minor/patch then it definitely will result in a change of behaviour for some.

@rarkins rarkins added needs-requirements priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others breaking Breaking change, requires major version bump labels Nov 13, 2018
@rarkins rarkins added this to the 14.0.0 milestone Nov 13, 2018
@rarkins rarkins removed this from the 14.0.0 milestone Jan 24, 2019
casdevs added a commit to casdevs/renovate that referenced this issue Nov 2, 2020
I noticed that `updateTypes: ['patch']` only matches if `separateMinorPatch` is set to true.
This comes somewhat unexpected and does not seem to be documented anywhere at the moment, as opposed to the documentation of the `patch` setting, where the docs correctly state `Only applies if separateMinorPatch is set to true`.

Maybe related to renovatebot#2818

But without reading the docs, I would expect `updateTypes: ['patch']` to always match on patch updates (e.g. 1.0.0 to 1.0.1) regardless of the `separateMinorPatch` setting (which is only set if we want separate PRs or branches for patch AND minor updates)
@viceice
Copy link
Member

viceice commented Nov 2, 2020

I think we should flip this with next major

@rarkins
Copy link
Collaborator Author

rarkins commented Nov 2, 2020

It's a non-trivial logic change so we'll need to make sure we test it thoroughly and think of whether there's any highly undesirable behavior changes that would result, assuming the majority of users won't update their config prior. There may also be some presets we want to update the definition of to get as much backwards compatibility that way

@rarkins rarkins added the status:requirements Full requirements are not yet known, so implementation should not be started label Jan 12, 2021
@rarkins rarkins self-assigned this Apr 4, 2021
rarkins added a commit that referenced this issue Apr 4, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
@rarkins rarkins mentioned this issue Apr 4, 2021
6 tasks
rarkins added a commit that referenced this issue Apr 4, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
rarkins added a commit that referenced this issue Apr 5, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
rarkins added a commit that referenced this issue Apr 5, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
rarkins added a commit that referenced this issue Apr 5, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
@rarkins rarkins mentioned this issue Apr 7, 2021
rarkins added a commit that referenced this issue Apr 7, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
rarkins added a commit that referenced this issue Apr 10, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
rarkins added a commit that referenced this issue Apr 11, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
rarkins added a commit that referenced this issue Apr 15, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
rarkins added a commit that referenced this issue Apr 21, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
rarkins added a commit that referenced this issue Apr 22, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
rarkins added a commit that referenced this issue Apr 22, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
rarkins added a commit that referenced this issue Apr 22, 2021
Changes behavior so that patch updateType is not rewritten to minor by default.

Closes #2818

BREAKING CHANGE: patch updates are not considered updateType=minor by default.
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 25.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@brechtvhb
Copy link

brechtvhb commented Apr 23, 2021

How do I keep the old behaviour?

  {
    "packagePatterns": [ "Common.*" ],
    "updateTypes": ["patch", "minor"],
    "versioning": "nuget",
    "groupName": "Common packages",
    "prPriority": 99
  },

Splits patch and minor's in 2 PRs. I want them in one PR.

@rarkins
Copy link
Collaborator Author

rarkins commented Apr 23, 2021

Can you create a reproduction repo and then a new discussion? We may need to experiment

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change, requires major version bump priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants