Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(manager/scalafmt): implement manager #28192

Merged
merged 7 commits into from Apr 1, 2024
Merged

Conversation

gaeljw
Copy link
Contributor

@gaeljw gaeljw commented Mar 31, 2024

Changes

This PR adds support for updating scalafmt version (#13877).

It does NOT add support for automatically reformating the codebase using the new scalafmt version as suggested in the issue, this could be implemented in a second step.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

@gaeljw gaeljw changed the title Add support for scalafmt feat(manager): add support for scalafmt Mar 31, 2024
@gaeljw gaeljw marked this pull request as ready for review March 31, 2024 13:14
lib/modules/manager/scalafmt/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/scalafmt/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/scalafmt/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/scalafmt/extract.ts Outdated Show resolved Hide resolved
lib/modules/manager/scalafmt/index.ts Outdated Show resolved Hide resolved
lib/modules/manager/scalafmt/extract.ts Outdated Show resolved Hide resolved
@gaeljw
Copy link
Contributor Author

gaeljw commented Apr 1, 2024

Thanks for the review @secustor 🙏

@gaeljw gaeljw requested a review from secustor April 1, 2024 12:07
@secustor secustor changed the title feat(manager): add support for scalafmt feat(manager/scalafmt): implement manager Apr 1, 2024
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else lgtm

lib/modules/manager/scalafmt/index.ts Outdated Show resolved Hide resolved
gaeljw and others added 2 commits April 1, 2024 14:26
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@gaeljw gaeljw requested a review from secustor April 1, 2024 12:34
@secustor secustor added this pull request to the merge queue Apr 1, 2024
Merged via the queue into renovatebot:main with commit 1119d60 Apr 1, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.279.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gaeljw gaeljw deleted the gh13877 branch April 1, 2024 15:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update version in .scalafmt.conf file
3 participants