Skip to content

feat(fleet): extract dependencies from helm blocks without a fixed releaseName #28325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

webD97
Copy link
Contributor

@webD97 webD97 commented Apr 10, 2024

Changes

This PR changes the schema so that all helm blocks in fleet match even if they don't set an explicit release name.

Context

Previously, the manager for fleet ignored a helm section if it does not have a releaseName set. According to the fleet.yaml docs this field is optional in both the top level helm block and in targetCustomizations. A previously undetected but valid example:

helm:
  repo: https://prometheus-community.github.io/helm-charts
  chart: prometheus
  version: 25.19.0

targetCustomizations:
  - name: target-1
    helm:
      repo: https://prometheus-community.github.io/helm-charts
      chart: prometheus
      version: 25.19.0

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Sorry, something went wrong.

Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing!

@secustor secustor added this pull request to the merge queue Apr 10, 2024
Merged via the queue into renovatebot:main with commit 7669f2f Apr 10, 2024
37 checks passed
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.284.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants