-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(host-rules): Support readOnly
request matching
#28562
Merged
rarkins
merged 8 commits into
renovatebot:main
from
zharinov:feat/host-rules-read-only-request-match
Apr 23, 2024
Merged
feat(host-rules): Support readOnly
request matching
#28562
rarkins
merged 8 commits into
renovatebot:main
from
zharinov:feat/host-rules-read-only-request-match
Apr 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
requested changes
Apr 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs documentation about how it works
rarkins
requested changes
Apr 22, 2024
viceice
previously approved these changes
Apr 22, 2024
rarkins
requested changes
Apr 22, 2024
Co-authored-by: Rhys Arkins <rhys@arkins.net>
rarkins
approved these changes
Apr 23, 2024
🎉 This PR is included in version 37.319.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
By the way, we accidentally put the new docs content in the wrong place. It was moved to the correct place with this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces matching against read-only requests, which is configured via
hostRules
.This is useful for off-loading the read requests to other users in order to avoid rate limit errors from platforms like GitHub or Bitbucket.
Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: